-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add contribution ladder #560
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sajay Antony <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comments:
- We should remove the wording that this is a template and adopt for this specific project
- We should define the two missing roles
@@ -0,0 +1,111 @@ | |||
# Contributor Ladder Template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the wording that this is a template and adjust it to the needs of the project.
|
||
* Responsibilities include: | ||
* Follow the code of conduct | ||
* Follow the project contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking to the guide would be good
* [Contributor Ladder](#contributor-ladder-template) | ||
* [Community Participant](#community-participant) | ||
* [Contributor](#contributor) | ||
* [Organization Member](#organization-member) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see descriptions of Org Member and Reviewer below. Are those defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that Ratify is not an ORG maybe when we move it and we can add it at that point in time since this would also need to be reviewed.
* Privileges: | ||
* Invitations to contributor events | ||
|
||
### Maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted that a maintainer can be on a project level (includes all sub-projects) or sub-project level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently Ratify doesn't have a sub project so do you want me to include the clause?
* Determining strategy and policy for the project | ||
* Participating in, and leading, community meetings | ||
* Requirements | ||
* Experience as a Reviewer for at least 4 months |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again Reviewer is not defined in this document.
* Have a vote in Maintainer decision-making meetings | ||
|
||
|
||
Process of becoming a maintainer: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there exceptions to this process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm considering not and if there are we should update this doc for transparency.
This PR might sit in draft form for a while since folks are ironing out definitions in related projects. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 51.72% 51.72%
=======================================
Files 61 61
Lines 3555 3555
=======================================
Hits 1839 1839
Misses 1529 1529
Partials 187 187 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sajay Antony [email protected]
Description
What this PR does / why we need it:
This add the contribution ladder template for the Ratify project and is based of https://github.com/cncf/project-template/blob/main/CONTRIBUTING.md
The current template outlines only a subset of roles.
/cc @bridgetkromhout @akashsinghal @toddysm @susanshi @binbin-li