This repository has been archived by the owner on May 19, 2021. It is now read-only.
Remove iOS 7 Hack & Black Superview #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to get some help and fix another issue I have been collaborating on. Closing this pull request to open a new one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes address some concerns I had as mentioned in issue #186 and issue #218 . This also solves the problem @joe-scotto is having in issue #228 . I am still working on how to add a black colored area under the bottom safe area on the iphone x, but I am very inexperienced in objective c programming. My thought is that an addition view needs to be created to fill this area (similar to bannerView, but lets name it "safeAreaView"). We would set the background of this view to black as it looks the nicesest. The view can then be positioned and turned on/off as needed when we shift the banner and webview up in the resizeViews function. I have no idea how to go about creating an additional view so some help would be needed here.