This repository has been archived by the owner on May 19, 2021. It is now read-only.
fix: Make plugin available for Ads SDK v17.0.0 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"com.google.android.gms.ads.AD_MANAGER_APP" isn't required too? https://developers.google.com/ad-manager/mobile-ads-sdk/android/quick-start |
|
This is only required if it's an Ad Manager app - I don't think that anyone is using Google Ad Manager :D I think they are using Admob |
|
Yes, sorry, my mistake. I read it again and it's one setting or the other, depending if you use admob or ad manager. +1 for this PR |
|
@paulstelzer Thank you for PR 👍 |
|
Hi, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #286
Add a new preference (ADMOB_APP_ID - like mentioned in https://developers.google.com/admob/android/quick-start#update_your_androidmanifestxml)
Update the android-manifest.xml by using the preference