-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rauc: split package into 'rauc' for binary and 'rauc-conf' for configuration #147
Conversation
1f271ca
to
da3c946
Compare
rebased onto master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the RDEPENDS += "rauc-conf"
it should be obvious enough to people updating from previous versions that the system.conf would need to move to rauc-conf
. Perhaps add a hint regarding that to the commit message nevertheless?
@ejoerns Any news on this PR? Would be nice to see it being merged. 🙂 It would make custom configurations a lot easier to handle. |
Indeed. And I currently work myself on a project where this should be quite useful, too. |
well... |
…uration This allows to build 'rauc' with default TUNE_PKGARCH while only 'rauc-conf' needs to be build for MACHINE_ARCH as it contains MACHINE-specific configuration. Another point is that the RAUC configuration may not only by MACHINE-specific but may also differ between images (for the same MACHINE). The rauc target package now RRECOMMENDS rauc-conf to pull this in by default. For providing your own configuration, either bbappend the existing rauc-conf recipe, write a new one that provides 'virtual-rauc-conf' and set PREFERRED_PROVIDER_virtual-rauc-conf or just write a custom one and add it to your image's IMAGE_INSTALL list (or any packagegroup). Either way, this requires migration in your rauc recipe(s)! Signed-off-by: Enrico Jorns <[email protected]>
This recipe just provides configuration, thus there is no need to compile anything nor do we need default (C compiler / C library) dependencies. Signed-off-by: Enrico Jorns <[email protected]>
da3c946
to
9802cf2
Compare
Rebased onto the current I was unsure about how strongly I wanted to couple Suggestions or objections welcome. |
With this change, anyone using |
I wanted to avoid having to bbappend the recipe file for this case and assumed that having no config at all might be noticed. Note that e.g. systemd pulls in systemd-conf via But maybe using |
OK. Then it's consistent, and it retract my criticism.
|
rauc: split package into 'rauc' for binary and 'rauc-conf' for configuration
This allows to build 'rauc' with default TUNE_PKGARCH while only 'rauc-conf' needs to be build for MACHINE_ARCH as it contains MACHINE-specific configuration.
Another point is that the RAUC configuration may not only by MACHINE-specific but may also differ between images (for the same MACHINE).
The rauc target package now
RRECOMMENDS
rauc-conf to pull this in by default.For providing your own configuration, either bbappend the existing rauc-conf recipe, write a new one that provides 'virtual-rauc-conf' and set
PREFERRED_PROVIDER_virtual-rauc-conf
or just write a custom one and add it to your image'sIMAGE_INSTALL
list (or any packagegroup).Either way, this requires migration in your rauc recipe(s)!