Sh 1106 refactor #120
Merged
Sh 1106 refactor #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ality, causing errors such as telemetry undetection and buttons lag. There is still a ~30ms hanging while OLED is being updated via I2C but is also present in main (SSD1306) branch and is does not seem to affect tracker
Graphics library is separated from low-level driver This simplifies both debugging and support of other OLED types in future Added some boundary checks for OLED buffer Done some formatting
…er results in random output and may corrupt memory. Removed unnecessary printing.
|
@raul-ortega can you please merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll back OLED update period to 200ms. 5ms totally breaks timing, affecting functionality.
Fixed column addressing bug.
Done some refactoring and formatting of display code. Split OLED driver into two parts - graphical (working with text or images) and low-level (pure HW driver) for greater control.
Testing is required for SSD1306 display as I do not have one. If OK, I think theese changes may be merged with development branch.