uhv: add http-parser permissive parsing for h1 codec (envoyproxy#20872)

Signed-off-by: Adam Meily <[email protected]>

bazel/external/http_parser/BUILD

@@ -10,7 +10,10 @@ cc_library(
     # This compiler flag is set to an arbtitrarily high number so
     # as to effectively disables the http_parser header limit, as
     # we do our own checks in the conn manager and codec.
-    copts = ["-DHTTP_MAX_HEADER_SIZE=0x2000000"],
+    copts = ["-DHTTP_MAX_HEADER_SIZE=0x2000000"] + select({
+        "@envoy//bazel:uhv_enabled": ["-DHTTP_PARSER_STRICT=0"],
+        "//conditions:default": [],
+    }),
     includes = ["."],
     visibility = ["//visibility:public"],
 )

test/common/http/http1/codec_impl_test.cc

@@ -3149,6 +3149,34 @@ TEST_F(Http1ServerConnectionImplTest, PipedRequestWithMutipleEvent) {
   connection_.dispatcher_.clearDeferredDeleteList();
 }
 
+TEST_F(Http1ServerConnectionImplTest, Utf8Path) {
+  initialize();
+
+  MockRequestDecoder decoder;
+  Buffer::OwnedImpl buffer("GET /δ¶/δt/pope?q=1#narf HXXP/1.1\r\n\r\n");
+#ifdef ENVOY_ENABLE_UHV
+  // permissive
+  EXPECT_CALL(callbacks_, newStream(_, _)).WillOnce(ReturnRef(decoder));
+
+  TestRequestHeaderMapImpl expected_headers{
+      {":path", "/δ¶/δt/pope?q=1#narf"},
+      {":method", "GET"},
+  };
+  EXPECT_CALL(decoder, decodeHeaders_(HeaderMapEqual(&expected_headers), true));
+
+  auto status = codec_->dispatch(buffer);
+  EXPECT_TRUE(status.ok());
+  EXPECT_EQ(0U, buffer.length());
+#else
+  // strict
+  EXPECT_CALL(callbacks_, newStream(_, _)).WillOnce(ReturnRef(decoder));
+
+  EXPECT_CALL(decoder, sendLocalReply(_, _, _, _, _));
+  auto status = codec_->dispatch(buffer);
+  EXPECT_TRUE(isCodecProtocolError(status));
+#endif
+}
+
 // Tests that incomplete response headers of 80 kB header value fails.
 TEST_F(Http1ClientConnectionImplTest, ResponseHeadersWithLargeValueRejected) {
   initialize();

test/extensions/filters/listener/http_inspector/http_inspector_test.cc

@@ -482,6 +482,11 @@ TEST_F(HttpInspectorTest, MultipleReadsHttp1IncompleteBadHeader) {
 }
 
 TEST_F(HttpInspectorTest, MultipleReadsHttp1BadProtocol) {
+#ifdef ENVOY_ENABLE_UHV
+  // permissive parsing
+  return;
+#endif
+
   const std::string valid_header = "GET /index HTTP/1.1\r";
   //  offset:                       0         10
   const std::string truncate_header = valid_header.substr(0, 14).append("\r");

test/integration/protocol_integration_test.cc

@@ -3510,6 +3510,11 @@ TEST_P(ProtocolIntegrationTest, UpstreamDisconnectBeforeResponseCompleteWireByte
 TEST_P(DownstreamProtocolIntegrationTest, BadRequest) {
   config_helper_.disableDelayClose();
   // we only care about upstream protocol.
+#ifdef ENVOY_ENABLE_UHV
+  // permissive parsing is enabled
+  return;
+#endif
+
   if (downstreamProtocol() != Http::CodecType::HTTP1) {
     return;
   }

tools/spelling/spelling_dictionary.txt

@@ -387,6 +387,7 @@ UA
 UBSAN
 UDP
 UDS
+UHV
 UNC
 URI
 URL