Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for get the old value of a switch toggle without livewire #41

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

luilliarcec
Copy link
Contributor

1️⃣ Is this something that is wanted/needed? Did you create an issue / discussion about it first?

A problem was not created, but it is something that is needed.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

It is a single related change.

3️⃣ Does it include tests, if possible? (Not a deal-breaker, just a nice-to-have)

No

4️⃣ Please include a thorough description of the improvement and reasons why it's useful.

The component was not getting the old value when submitting a form and getting errors (speaking outside of livewire), what was added was support for that functionality.

5️⃣ Thanks for contributing! 🙌

@rawilk
Copy link
Owner

rawilk commented Jan 7, 2022

Thanks for taking the time to create a PR for this repository. I'm planning on releasing a new version next week and I don't see any issues from making this change, so I'll probably merge this PR next week sometime.

@rawilk rawilk added the bug Something isn't working label Jan 7, 2022
@rawilk rawilk merged commit b3dea52 into rawilk:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants