Filter alarm changelog by entity #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def callback(driver, options, args, callback): | ||
| callback(driver.list_alarm_changelog(ex_next_marker=options.marker)) | ||
| entity = None | ||
| if options.entity_id is not None: |
There was a problem hiding this comment.
I think I'd check for a truthy value here instead of checking explicitly for is not None.
There was a problem hiding this comment.
Never mind on this. After talking to @fourk this is intended behavior.
There was a problem hiding this comment.
If a user attempts to run this using something like raxmon-alarms-changelog-list --entity-id="", I believe that it makes more sense to give them a 400 error for an invalid entityId, rather than give them an unfiltered response.
|
👍 LGTM |
…log_by_entity_id Conflicts: commands/raxmon-alarms-changelog-list
|
RFR, entity filtering functionality should be live in production now |
|
what's the word? 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFR -- pending https://github.com/racker/rackspace-monitoring/pull/13