fix: compact react plugin targets is undefined (#490)

raxjs · Nov 18, 2020 · 98426dd · 98426dd
1 parent 6947124
commit 98426dd
Show file tree

Hide file tree

Showing 14 changed files with 122 additions and 17 deletions.
diff --git a/examples/basic-compat-react/README.md b/examples/basic-compat-react/README.md
@@ -0,0 +1,2 @@
+# Basic compact with react
+
diff --git a/examples/basic-compat-react/build.json b/examples/basic-compat-react/build.json
@@ -0,0 +1,5 @@
+{
+  "targets": ["web"],
+  "plugins": ["build-plugin-rax-compat-react"],
+  "store": false
+}
diff --git a/examples/basic-compat-react/package.json b/examples/basic-compat-react/package.json
@@ -0,0 +1,22 @@
+{
+  "name": "with-rax",
+  "description": "rax example",
+  "dependencies": {
+    "rax": "^1.1.0",
+    "rax-document": "^0.1.0",
+    "rax-image": "^2.0.0",
+    "rax-link": "^1.0.1",
+    "rax-text": "^1.0.0",
+    "rax-view": "^1.0.0"
+  },
+  "devDependencies": {
+    "@types/rax": "^1.0.0"
+  },
+  "scripts": {
+    "start": "rax-app start",
+    "build": "rax-app build"
+  },
+  "engines": {
+    "node": ">=8.0.0"
+  }
+}
diff --git a/examples/basic-compat-react/src/app.json b/examples/basic-compat-react/src/app.json
@@ -0,0 +1,11 @@
+{
+  "routes": [
+    {
+      "path": "/",
+      "source": "pages/Home/index"
+    }
+  ],
+  "window": {
+    "title": "Rax App"
+  }
+}
diff --git a/examples/basic-compat-react/src/app.tsx b/examples/basic-compat-react/src/app.tsx
@@ -0,0 +1,28 @@
+import { createElement } from 'rax';
+import { runApp } from 'rax-app';
+
+runApp({
+  router: {
+    type: 'browser',
+  },
+  app: {
+    // ErrorBoundary
+    errorBoundary: true,
+
+    // 生命周期
+    onShow() {
+      console.log('app show...');
+    },
+    onHide() {
+      console.log('app hide...');
+    },
+
+    // 获取初始数据
+    getInitialData: async () => {
+      return {
+        a: 1,
+        b: 2,
+      };
+    },
+  },
+});
diff --git a/examples/basic-compat-react/src/document/index.jsx b/examples/basic-compat-react/src/document/index.jsx
@@ -0,0 +1,22 @@
+import { createElement } from 'rax';
+import { Root, Style, Script, Data } from 'rax-document';
+
+function Document(props) {
+  return (
+    <html>
+      <head>
+        <meta charset="utf-8" />
+        <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scale=1,minimum-scale=1,user-scalable=no,viewport-fit=cover" />
+        <title>@ali/demo-app</title>
+        <Style />
+      </head>
+      <body>
+        {/* root container */}
+        <Root />
+        <Data />
+        <Script />
+      </body>
+    </html>
+  );
+}
+export default Document;
diff --git a/examples/basic-compat-react/src/pages/Home/index.css b/examples/basic-compat-react/src/pages/Home/index.css
@@ -0,0 +1,16 @@
+.home {
+  align-items: center;
+  margin-top: 200rpx;
+}
+
+.title {
+  font-size: 35rpx;
+  font-weight: bold;
+  margin: 20rpx 0;
+}
+
+.info {
+  font-size: 36rpx;
+  margin: 8rpx 0;
+  color: #555;
+}
diff --git a/examples/basic-compat-react/src/pages/Home/index.tsx b/examples/basic-compat-react/src/pages/Home/index.tsx
@@ -0,0 +1,10 @@
+import React from 'react';
+
+import './index.css';
+
+export default function Home() {
+  return (
+    React.createElement('div', {}, [123])
+  );
+}
+
diff --git a/examples/with-rax-miniapp-compile/README.md b/examples/with-rax-miniapp-compile/README.md
@@ -1,3 +1 @@
 # with rax miniapp compile
-
-https://github.com/ice-lab/icejs/tree/master/examples
diff --git a/examples/with-rax-mpa/README.md b/examples/with-rax-mpa/README.md
@@ -1,3 +1 @@
 # with rax mpa
-
-https://github.com/ice-lab/icejs/tree/master/examples
diff --git a/examples/with-rax-store/README.md b/examples/with-rax-store/README.md
@@ -1,3 +1 @@
 # with rax
-
-https://github.com/ice-lab/icejs/tree/master/examples
diff --git a/examples/with-rax/README.md b/examples/with-rax/README.md
@@ -1,3 +1 @@
 # with rax
-
-https://github.com/ice-lab/icejs/tree/master/examples
diff --git a/examples/with-rax/build.json b/examples/with-rax/build.json
@@ -1,3 +1,3 @@
 {
-  "targets": ["kraken"]
+  "targets": ["web", "weex", "kraken", "miniapp", "wechat-miniprogram"]
 }
diff --git a/packages/plugin-rax-compat-react/src/index.js b/packages/plugin-rax-compat-react/src/index.js
@@ -1,10 +1,7 @@
-module.exports = ({ onGetWebpackConfig, getValue }) => {
-  const targets = getValue('targets');
-  targets.forEach((target) => {
-    onGetWebpackConfig(target, (config) => {
-      config.resolve.alias
-        .set('react', 'rax/lib/compat')
-        .set('react-dom', 'rax-dom');
-    });
+module.exports = ({ onGetWebpackConfig }) => {
+  onGetWebpackConfig((config) => {
+    config.resolve.alias
+      .set('react', 'rax/lib/compat')
+      .set('react-dom', 'rax-dom');
   });
 };
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1 @@
		# with rax miniapp compile

		https://github.com/ice-lab/icejs/tree/master/examples
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1 @@
		# with rax mpa

		https://github.com/ice-lab/icejs/tree/master/examples
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1 @@
		# with rax

		https://github.com/ice-lab/icejs/tree/master/examples