[Feature][Helm] Align the key of minReplicas and maxReplicas (#663)

* [Feature][Helm] Align the key of minReplicas and maxReplicas Signed-off-by: Andrew Li <[email protected]> * [Feature][Helm] Updated the values.yaml after align the key of minReplicas and maxReplicas Signed-off-by: Andrew Li <[email protected]> * [Feature][Helm] Added backwards compatibility of "maxiReplicas"/"miniReplicas" using default function Signed-off-by: Andrew Li <[email protected]> Signed-off-by: Andrew Li <[email protected]>
ray-project · Nov 1, 2022 · 310911c · 310911c
1 parent 56b2f61
commit 310911c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/helm-chart/ray-cluster/templates/raycluster-cluster.yaml b/helm-chart/ray-cluster/templates/raycluster-cluster.yaml
@@ -67,8 +67,8 @@ spec:
       {{ $key }}: {{ $val | quote }}
     {{- end }}
     replicas: {{ $values.replicas }}
-    minReplicas: {{ $values.miniReplicas | default 1 }}
-    maxReplicas: {{ $values.maxiReplicas | default 2147483647 }}
+    minReplicas: {{ $values.minReplicas | default (default 1 $values.miniReplicas) }}
+    maxReplicas: {{ $values.maxReplicas | default (default 2147483647 $values.maxiReplicas) }}
     groupName: {{ $groupName }}
     template:
       spec:
@@ -117,8 +117,8 @@ spec:
       {{ $key }}: {{ $val | quote }}
     {{- end }}
     replicas: {{ .Values.worker.replicas }}
-    minReplicas: {{ .Values.worker.miniReplicas | default 1 }}
-    maxReplicas: {{ .Values.worker.maxiReplicas | default 2147483647 }}
+    minReplicas: {{ .Values.worker.minReplicas | default (default 1 .Values.worker.miniReplicas) }}
+    maxReplicas: {{ .Values.worker.maxReplicas | default (default 2147483647 .Values.worker.maxiReplicas) }}
     groupName: {{ .Values.worker.groupName }}
     template:
       spec:

diff --git a/helm-chart/ray-cluster/values.yaml b/helm-chart/ray-cluster/values.yaml
@@ -113,8 +113,8 @@ additionalWorkerGroups:
     # Disabled by default
     disabled: true
     replicas: 1
-    miniReplicas: 1
-    maxiReplicas: 3
+    minReplicas: 1
+    maxReplicas: 3
     type: worker
     labels: {}
     initArgs: