Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ascertain the minimum essential rayStartParams and make rayStartParams optional #976

Closed
2 of 3 tasks
Yicheng-Lu-llll opened this issue Mar 19, 2023 · 0 comments · Fixed by #1057
Closed
2 of 3 tasks
Assignees
Labels
enhancement New feature or request

Comments

@Yicheng-Lu-llll
Copy link
Contributor

Yicheng-Lu-llll commented Mar 19, 2023

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

As #368 suggests, Figure out the minimum configurations required for a successful Ray start and make rayStartParams optional.

  • : Review the Ray start options (refer to Ray start documentation) and provide explanations for each option, as well as determine their necessity for inclusion in the default configurations.

[WIP]Test:

rootPath="/home/ubuntu/kuberay"
outputFile="./original-ray-start-command.txt"
cd $rootPath

for file in $rootPath/ray-operator/config/samples/ray-cluster*.yaml
do
  echo "###########################"  >> $outputFile

  echo $file >> $outputFile

  kubectl apply -f $file
  kubectl get  $(kubectl get pods -o=name | grep head) -o yaml | grep "ulimit -n 65536; ray start" >> $outputFile
  kubectl get  $(kubectl get pods -o=name | grep worker) -o yaml | grep "ulimit -n 65536; ray start" >> $outputFile
  kubectl delete -f $file

  echo "###########################\n"  >> $outputFile
done

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants