-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a document to outline the default settings for rayStartParams
in Kuberay
#1057
Merged
kevin85421
merged 8 commits into
ray-project:master
from
Yicheng-Lu-llll:make-rayStartParams-optional
May 22, 2023
Merged
Add a document to outline the default settings for rayStartParams
in Kuberay
#1057
kevin85421
merged 8 commits into
ray-project:master
from
Yicheng-Lu-llll:make-rayStartParams-optional
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yicheng-Lu-llll
force-pushed
the
make-rayStartParams-optional
branch
2 times, most recently
from
May 3, 2023 02:52
9f213b5
to
c16d78d
Compare
Yicheng-Lu-llll
force-pushed
the
make-rayStartParams-optional
branch
from
May 8, 2023 21:43
e43adb5
to
375ea93
Compare
Yicheng-Lu-llll
changed the title
Make ray start params optional
Add a document to outline the default settings for May 11, 2023
rayStartParams
in Kuberay
Yicheng-Lu-llll
force-pushed
the
make-rayStartParams-optional
branch
from
May 11, 2023 19:53
0c35d19
to
c3a7675
Compare
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Yicheng-Lu-llll
force-pushed
the
make-rayStartParams-optional
branch
from
May 12, 2023 02:17
4862938
to
4e87ca3
Compare
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
kevin85421
reviewed
May 15, 2023
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
kevin85421
reviewed
May 16, 2023
The default value for both Ray and KubeRay 0.5.0 is `localhost`, however, for versions of KubeRay after 0.5.0, the default value will be `0.0.0.0`. | ||
|
||
|
||
- `--no-monitor`: This option disables the monitor and autoscaler in the **user's container**. It will be automatically set when [autoscaling](https://github.com/ray-project/kuberay/blob/master/docs/guidance/autoscaler.md) is enabled. The autoscaling feature introduces the autoscaler as a sidecar container within the head pod, thereby obviating the need for a monitor and autoscaler in the **user's container**. See [PR #13505](https://github.com/ray-project/ray/pull/13505) for more details. Modification is not recommended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitriGekhtman would you mind reviewing the option --no-monitor
?
kevin85421
reviewed
May 16, 2023
Signed-off-by: Yicheng-Lu-llll <[email protected]>
kevin85421
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…n Kuberay (ray-project#1057) Add a document to outline the default settings for `rayStartParams` in Kuberay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR:
rayStartParams
in Kuberay(see here for the ray start cli).dashboard-host
will now be automatically injected with the value '0.0.0.0'.num-cpus
in all sample yaml file. Thenum-cpus
value should be automatically determined based on thecontainer.resource.cpu.limit
. Refer to add resource command #170 for more information.TODO:
dashboard-host
after releasing 0.6.0 and change the document accordingly.Related issue number
Closes #976
Checks
I have run all the sample yaml files and fetched the ray start command to make sure all the options Kuberay may set by default for
rayStartParams
are included.