Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE][Experiment] RayService updates status frequently #1062

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented May 2, 2023

Why are these changes needed?

# Build Docker image
make docker-image

# Install KubeRay operator
helm install kuberay-operator kuberay/kuberay-operator --version 0.5.0 --set image.repository=controller,image.tag=latest

# Create a RayService (path: ray-operator/config/samples)
kubectl apply -f ray_v1alpha1_rayservice.yaml

# Collect operator logs after 10 mins
kubectl logs kuberay-operator-xxxxxx | tee operator-log
cat operator-log | grep "r.Status().Update()" | tee experiment_result
  • r.Status().Update() is called 287 times in 10 mins.
    • 41 times: RayCluster is not ready.
      2023-05-02T21:46:18.091Z	INFO	controllers.RayService	r.Status().Update() updateState	{"error": "Put \"http://rayservice-sample-raycluster-7wgsc-dashboard-svc.default.svc.cluster.local:52365/api/serve/deployments/\": dial tcp 10.96.145.214:52365: connect: connection refused"}
      
    • 7 times
      2023-05-02T21:46:27.278Z	INFO	controllers.RayService	r.Status().Update() isHealthy && !isReady
      
    • 239 times
      2023-05-02T21:46:42.046Z	INFO	controllers.RayService	r.Status().Update() Final status update for any CR modification.
      

Related issue number

Experiments for #1061

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant