-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RayService] Stable Diffusion example #1181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far! I left some comments.
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
@@ -10,7 +10,8 @@ kind create cluster --image=kindest/node:v1.23.0 | |||
|
|||
## Step 2: Install KubeRay operator | |||
|
|||
Follow [this document](../../helm-chart/kuberay-operator/README.md) to install the latest stable KubeRay operator via Helm repository. | |||
Follow [this document](../../helm-chart/kuberay-operator/README.md) to install the nightly KubeRay operator via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @zcin
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all my comments! This change looks great!
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
Co-authored-by: shrekris-anyscale <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
cc @shrekris-anyscale I have relocated the installation instructions for the NVIDIA device plugin to the appropriate location. Thanks! a071fe3 |
Awesome, thanks! This change looks ready to merge. |
Stable Diffusion example
Why are these changes needed?
docs/guidance/aws-eks-gpu-cluster.md
: Most content here is the same as https://github.com/ray-project/aviary/blob/master/docs/kuberay/deploy-on-eks.md.Update MobileNet doc and YAML to encourage users to use the nightly KubeRay operator.
An example for Stable Diffusion
Related issue number
Checks