[Bug] fix RayActorOptionSpec.items.spec.serveConfig.deployments.rayActorOptions.memory int32 data type #1220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Based on actor.py, the unit of
memory
is specified as "byte". However, the data type ofMemory
inRayActorOptionSpec
is specified as int32. The maximum value of int32 is 2^31 - 1. Therefore, if a user specifies a value larger than 2GB (2^31 bytes), it will result in an overflow. Hence, this PR updates the data type to uint64 instead.proto/
: I only updatedserve.proto
, and the other changes were generated bymake generate
.CRD
ray.io_rayservices.yaml
: This is entirely maintained by the code generator. It's worth noting that YAML does not support unsigned integers [1], so in the CRD, the type is int64 instead of uint64.Related issue number
Closes #1212
Checks
rayActorOptions.memory
for PearStand to 3 * 1024 * 1024 * 1024 (3GB).