Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RayJob] Add default CPU and memory for job submitter pod #1319

Merged
merged 7 commits into from
Oct 5, 2023
Merged

[RayJob] Add default CPU and memory for job submitter pod #1319

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
04e835d
Add default CPU and memory for job submitter pod
architkulkarni Aug 11, 2023
3002535
Merge branch 'master' of https://github.com/ray-project/kuberay into …
architkulkarni Aug 11, 2023
d56f803
Remove RayJob sample yaml test from github actions
architkulkarni Aug 11, 2023
a109a31
Update limits and resources using benchmark
architkulkarni Sep 28, 2023
c20630b
Revert "Remove RayJob sample yaml test from github actions"
architkulkarni Sep 28, 2023
5075963
Merge branch 'add-resources' of https://github.com/architkulkarni/kub…
architkulkarni Sep 28, 2023
5ff22f1
Merge branch 'master' of https://github.com/ray-project/kuberay into …
architkulkarni Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ray-operator/controllers/ray/common/job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"github.com/google/shlex"
rayv1alpha1 "github.com/ray-project/kuberay/ray-operator/apis/ray/v1alpha1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
"sigs.k8s.io/yaml"
)

Expand Down Expand Up @@ -154,6 +155,16 @@ func GetDefaultSubmitterTemplate(rayJobInstance *rayv1alpha1.RayJob) v1.PodTempl
{
Name: "ray-job-submitter",
Image: image,
Resources: v1.ResourceRequirements{
Limits: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("1"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we select 1 CPU and 1 GB of memory rather than other values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a guess. Let me try to benchmark it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated using the benchmark result.

v1.ResourceMemory: resource.MustParse("1Gi"),
},
Requests: v1.ResourceList{
v1.ResourceCPU: resource.MustParse("500m"),
v1.ResourceMemory: resource.MustParse("200Mi"),
},
},
},
},
RestartPolicy: v1.RestartPolicyNever,
Expand Down