Bump the golangci-lint version in the api server makefile #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z103cb
changed the title
|
@blublinsky, @tedhtchang, @scarlet25151 and @anishasthana, cc: @kevin85421 |
blublinsky
approved these changes
Aug 17, 2023
| @@ -122,7 +122,7 @@ KIND ?= $(REPO_ROOT_BIN)/kind | |||
| KUSTOMIZE_VERSION ?= v3.8.7 | |||
| GOFUMPT_VERSION ?= v0.3.1 | |||
| GOIMPORTS_VERSION ?= latest | |||
| GOLANGCI_LINT_VERSION ?= v1.50.1 | |||
| GOLANGCI_LINT_VERSION ?= v1.54.1 | |||
| KIND_VERSION ?= v0.19.0 | |||
There was a problem hiding this comment.
Do we have to put here a specific version? Can we just use the latest? Or figure out the version based on the go version? I am a bit concerned with the maintenance of updating the version constantly.
There was a problem hiding this comment.
No. I think we should pin the version as it will give us consistent builds. The maintenance is small price to pay.
There was a problem hiding this comment.
Agreed that we should pin the verison
anishasthana
approved these changes
Aug 17, 2023
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 22, 2023
…t#1342) Bump the golangci-lint version in the api server makefile
blublinsky
pushed a commit
to blublinsky/kuberay
that referenced
this pull request
Aug 25, 2023
…t#1342) Bump the golangci-lint version in the api server makefile
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…t#1342) Bump the golangci-lint version in the api server makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The version of
golangci-lintused in the KubeRay api server hangs when used with higher versions of golang (1.20+). This is related to this issueRelated issue number
Closes #1334
Checks