[Release][Doc] Add instructions to release Go modules. #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pingsutw |
|
Thank you so much! |
pingsutw
reviewed
Oct 19, 2023
| @@ -74,6 +74,27 @@ You will prompted for a commit reference and an image tag. The commit reference | |||
| git push upstream v0.5.0-rc.0 | |||
| ``` | |||
|
|
|||
| * Tag the tip of the release branch as `ray-operator/vX.Y.Z-rc.0`. Without this tag, users won't be able to use `github.com/ray-project/kuberay/[email protected]` to install the Go module. KubeRay starts supporting Go modules from v0.6.0. | |||
| ```sh | |||
| git tag ray-operator/v0.5.0-rc.0 | |||
There was a problem hiding this comment.
Maybe we can just add it to the CI. https://github.com/ray-project/kuberay/blob/master/.github/workflows/image-release.yaml
architkulkarni
approved these changes
Oct 19, 2023
2 tasks
kevin85421
added a commit
to kevin85421/kuberay
that referenced
this pull request
Nov 2, 2023
kevin85421
added a commit
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some KubeRay users, like Flyte, want to use the generated Golang client by
go install github.com/ray-project/kuberay/[email protected]. However, there is nogo.modin the root directory of KubeRay repo, so users cannot do that until we provide a specific tag forray-operator/directory.Related issue number
Checks