Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Server] Add security context to Ray Cluster #2538

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

han-steve
Copy link
Contributor

Why are these changes needed?

Adding the ability to customize the security context for a ray cluster. This is useful for adding necessary permissions to profile a ray cluster. For example, for py-spy to work, we need to add

# `py-spy` is a sampling profiler that requires `SYS_PTRACE` to read process memory effectively.
# Once enabled, you can profile Ray worker processes through Ray Dashboard.
# For more details, refer to:
# https://docs.ray.io/en/latest/ray-observability/user-guides/debug-apps/optimize-performance.html#python-cpu-profiling-in-the-dashboard
securityContext:
  capabilities:
    add:
    - SYS_PTRACE

as documented here.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Contributor

@YQ-Wang YQ-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, thanks!

apiserver/pkg/model/converter.go Show resolved Hide resolved
apiserver/pkg/model/converter.go Outdated Show resolved Hide resolved
@YQ-Wang
Copy link
Contributor

YQ-Wang commented Nov 13, 2024

cc @kevin85421 @andrewsykim

@kevin85421 kevin85421 self-assigned this Nov 13, 2024
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yiqing has already approved the PR. Merge.

@kevin85421 kevin85421 merged commit f3353b2 into ray-project:master Nov 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants