refactor: remove redundant imports #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
force-pushed
the
patch5
branch
2 times, most recently
from
204af01 to
9b689a8
Compare
Jeffwan
approved these changes
Jun 28, 2022
|
It should be very safe to merge. The PR excludes unnecessary imports and use corev1 consistently across all files. |
|
@davidxia Could you help resolve rebase the master and I can help merge the PR |
davidxia
force-pushed
the
patch5
branch
3 times, most recently
from
1cc608c to
9f50c97
Compare
|
rebased! |
and change import names accordingly. My IDE was complaining about these redundant imports.
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
and change import names accordingly. My IDE was complaining about these redundant imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and change import names accordingly. My IDE was complaining about
these redundant imports.
Checks