Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ray-operator version in the apiserver #340

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

pingsutw
Copy link
Contributor

@pingsutw pingsutw commented Jul 5, 2022

Signed-off-by: Kevin Su [email protected]

Why are these changes needed?

Update ray-operator version in the apiserver, so we're able to import it from other repos. Otherwise, we'll get the below error.

go: github.com/ray-project/kuberay/[email protected]: reading github.com/ray-project/kuberay/proto/proto/go.mod at revision proto/v0.0.0: unknown revision proto/v0.0.0

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 5, 2022

Sounds reasonable. Ideally, we should export the apis and client-go separately. This can be done later if we have other usages.

@Jeffwan Jeffwan merged commit 9434155 into ray-project:master Jul 6, 2022
@pingsutw
Copy link
Contributor Author

pingsutw commented Jul 6, 2022

Thank you @Jeffwan

lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants