Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoscaler] Flip prioritize-workers-to-delete feature flag #379

Conversation

DmitriGekhtman
Copy link
Collaborator

@DmitriGekhtman DmitriGekhtman commented Jul 15, 2022

Why are these changes needed?

This PR

Related issue number

Closes #357

Checks

  • I've made sure the tests are passing.
  • Testing Strategy

The relevant behavior is tested by the autoscaling integration test in the Ray repo.

Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 15, 2022

minor: Let's include prioritize-workers-to-delete in the PR title. The current title seems infer we flip all flags.

@DmitriGekhtman DmitriGekhtman changed the title [autoscaler] Flip feature flag [autoscaler] Flip prioritize-workers-to-delete feature flag Jul 15, 2022
@DmitriGekhtman DmitriGekhtman merged commit 022eed1 into ray-project:master Jul 15, 2022
@sriram-anyscale
Copy link
Collaborator

LGTM

@DmitriGekhtman DmitriGekhtman deleted the dmitri/flip-prioritize-workers-to-delete branch July 18, 2022 20:27
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…ect#379)

This PR

Flips the flag introduced in Prioritize WorkersToDelete ray-project#208. This allows the autoscaler to function properly without additional configuration of the operator deployment.

Updates the docs accordingly.

Makes minor tweaks to the autoscaling documentation, including documenting recently added fields to the sample config.

Updates the default autoscaler image with changes from Ray upstream, to include the bug fix from [KubeRay][Autoscaler][Core] Add a flag to disable ray status version check ray#26584.

Signed-off-by: Dmitri Gekhtman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Flip feature flags
6 participants