-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autoscaler] Flip prioritize-workers-to-delete feature flag #379
Merged
DmitriGekhtman
merged 13 commits into
ray-project:master
from
DmitriGekhtman:dmitri/flip-prioritize-workers-to-delete
Jul 15, 2022
Merged
[autoscaler] Flip prioritize-workers-to-delete feature flag #379
DmitriGekhtman
merged 13 commits into
ray-project:master
from
DmitriGekhtman:dmitri/flip-prioritize-workers-to-delete
Jul 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
Signed-off-by: Dmitri Gekhtman <[email protected]>
ncoish
reviewed
Jul 15, 2022
Signed-off-by: Dmitri Gekhtman <[email protected]>
Jeffwan
approved these changes
Jul 15, 2022
minor: Let's include |
DmitriGekhtman
changed the title
[autoscaler] Flip feature flag
[autoscaler] Flip prioritize-workers-to-delete feature flag
Jul 15, 2022
LGTM |
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
…ect#379) This PR Flips the flag introduced in Prioritize WorkersToDelete ray-project#208. This allows the autoscaler to function properly without additional configuration of the operator deployment. Updates the docs accordingly. Makes minor tweaks to the autoscaling documentation, including documenting recently added fields to the sample config. Updates the default autoscaler image with changes from Ray upstream, to include the bug fix from [KubeRay][Autoscaler][Core] Add a flag to disable ray status version check ray#26584. Signed-off-by: Dmitri Gekhtman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR
Related issue number
Closes #357
Checks
The relevant behavior is tested by the autoscaling integration test in the Ray repo.