Add RayJob docs and development docs #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
requested review from
wilsonwang371,
scarlet25151 and
DmitriGekhtman
and removed request for
wilsonwang371
docs/guidance/rayjob.md
Outdated
|
|
||
| A RayService manages 2 things: | ||
| * RayCluster: Manages resources in kubernetes cluster. | ||
| * Ray Serve Deployment Graph: Manages users' serve deployment graph. |
There was a problem hiding this comment.
We should probably link to the Ray docs to explain what a Ray Serve Deployment Graph is.
cc @simon-mo @brucez-anyscale
There was a problem hiding this comment.
I originally copy some contents and structure from RayService and forget to clean them up. Now it's in good shape
| @@ -0,0 +1,129 @@ | |||
| ## Ray Job (alpha) | |||
There was a problem hiding this comment.
We should explain what the operational difference is between a Ray Service and a Ray Job.
There was a problem hiding this comment.
Add some details. The cluster can be deleted by RayJob controller once it succeed or failed
|
cc @harryge00 |
|
@DmitriGekhtman @harryge00 Please have another check. it just have RayJob content now |
|
lgtm |
DmitriGekhtman
approved these changes
Jul 25, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Add RayJob docs and development docs * Address code review feedbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #349
Why are these changes needed?
Testing
Open
localhost:8000Checks