[api server] enable job spec server #416
Conversation
Basasuya
force-pushed
the
basasuya_master_job_api_server
branch
from
01cbeb7 to
254e64f
Compare
|
|
||
| func (s *RayJobServer) CreateRayJob(ctx context.Context, request *api.CreateRayJobRequest) (*api.RayJob, error) { | ||
| // use the namespace in the request to override the namespace in the job definition | ||
| request.Job.Namespace = request.Namespace |
There was a problem hiding this comment.
for creation, let's do a validation first. check how raycluster did and we can raise some 400 issues.
There was a problem hiding this comment.
@Basasuya This is necessary to reduce error creation in cluster. Let's add some validation here.
There was a problem hiding this comment.
after manual test, job create/list/delete would be OK. but after ray cluster create, seems job can not run through.
There was a problem hiding this comment.
I feel that's a job configuration issue. It works on my side and let's discuss this issue offline.
|
Let's run this command to fix the lint issue |
@Jeffwan fixed |
Basasuya
changed the title
|
Overall looks good to me. I will leave this change for a while. after v0.3.0 official release, we can merge it to avoid conflicts (fix on master can not be easily cherry-picked into v0.3.0) |
* [api server] enable job spec server * fix for lint * fix for review * fix * fix for lint * fix for review * fix UT / add encoding for runtime env
Why are these changes needed?
add job spec server implement for job server
Related issue number
#389
Checks