Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm chart version to 0.3.0 #461

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Aug 11, 2022

Address #452

Why are these changes needed?

Make helm chart version to match release version.

Related issue number

#452

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Jeffwan Jeffwan requested a review from scarlet25151 August 11, 2022 16:52
@scarlet25151
Copy link
Collaborator

scarlet25151 commented Aug 11, 2022

All changes have been bumped to 0.3.0, LGTM.

@Jeffwan Jeffwan merged commit 135d661 into ray-project:master Aug 11, 2022
@Jeffwan Jeffwan deleted the update_helm_chart_version branch August 11, 2022 17:29
Jeffwan added a commit to Jeffwan/kuberay that referenced this pull request Aug 16, 2022
Jeffwan added a commit that referenced this pull request Aug 16, 2022
* Update helm chart version to 0.3.0 (#461)

* helm-charts/ray-cluster: Allow extra workers (#451)

* helm-charts/ray-cluster: Allow extra workers

We can not set additional workers with the current helm chart.
There are some PRs that aim to fix this but they appear to be stale
#266

We wanted to keep untouched the default worker that is already
included in the helm chart but allow the addition of new workers.

The changes are adding the following logic:
- Allow to disable the default worker group, if needed, via worker.disabled = true
- Allow to set additional workers by using the extraWorkers map

The extraWorkers map has a different structure compared to the default worker because we
wanted to add additional flexibility. Due to that, some variables in the extraWorkers
have different naming (which matches the name of the related CRD attributed)

Note: PR was done to support additional workers in the infrastructure of Metrika.co

* Sync up helm chart's role (#472)

Co-authored-by: chenyu.jiang <[email protected]>

* Document the raycluster status (#473)

Co-authored-by: chenyu.jiang <[email protected]>

Co-authored-by: Christos Kotsis <[email protected]>
Co-authored-by: Chenyu Jiang <[email protected]>
Co-authored-by: chenyu.jiang <[email protected]>
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants