-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly convert unix time into meta time #480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Jeffwan
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement!
@pingsutw Do you rebase remote/master to your HEAD. the last test case doesn't go through, It's definitely not the issue of your code. I am just curious if there's any release blocker problem. |
Merged master to this branch. Hope the tests will pass. |
Jeffwan
pushed a commit
to Jeffwan/kuberay
that referenced
this pull request
Aug 16, 2022
* Add timeout to the query parameters Signed-off-by: Kevin Su <[email protected]> * Properly convert unix time into meta time Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Jeffwan
added a commit
that referenced
this pull request
Aug 17, 2022
* Fix panic in cleanupInvalidVolumeMounts (#481) * fix * assert * refine * Properly convert unix time into meta time (#480) * Add timeout to the query parameters Signed-off-by: Kevin Su <[email protected]> * Properly convert unix time into meta time Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: WanXing Wang <[email protected]> Co-authored-by: Kevin Su <[email protected]>
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Add timeout to the query parameters Signed-off-by: Kevin Su <[email protected]> * Properly convert unix time into meta time Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Failed to convert Unix time to meta time.
We should divide Unix time by 1000 because Ray job info returns the start_time in ms format.
https://docs.ray.io/en/latest/cluster/jobs-package-ref.html#jobinfo
Related issue number
Checks