Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm default #499

Closed

Conversation

bplotnick-humane
Copy link

Why are these changes needed?

Introduced in #451. Without a default value, helm throws:

... error calling ne: incompatible types for comparison

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@DmitriGekhtman
Copy link
Collaborator

@bplotnick-humane could you clarify what bug you encountered, and with what inputs to helm install?
I did not encounter any issues helm installing the default ray-cluster chart from master.

@bplotnick-humane
Copy link
Author

You can repro this with: helm template . from within the kuberay/helm-chart/ray-cluster directory

@DmitriGekhtman
Copy link
Collaborator

You can repro this with: helm template . from within the kuberay/helm-chart/ray-cluster directory

Which commit are using locally (git rev-parse HEAD)?
I do not get an error with current master.

@kevin85421
Copy link
Member

This issue will only happen in old helm versions. See #548 for more details. This issue and #537 #543 are duplicate. Thank @bplotnick-humane for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants