[Feature][Helm] Enable sidecar configuration in Helm chart #584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR exposed an interface in KubeRay helm charts to enable users to configure sidecar containers (See the logging documentation and #353 for more details).
Explanation of the interface:
.Values.fluentBitConfigMaps
.Values.fluentBitConfigMaps[0].name
: Name of the ConfigMap..Values.fluentBitConfigMaps[0].fluentBitConf
: Used to configurefluentBit
. Note that this configuration assumes logs are mounted on/tmp/ray
..Values.{head, worker, additionalWorkerGroups.smallGroup}.fluentBitConfigMap
enabled
: Whether enable sidecar feature on the head, worker, and smallGroup pods. This configuration is optional, and the default value is false.logVolumeMount.mountPath
: The mount path of the log volume should be synchronized with.Values.fluentBitConfigMaps.fluentBitConf
logVolumeMount.name
: This field should be synchronized with.Values.{head, worker, additionalWorkerGroups.smallGroup}.volumes
.configMapName
: The config map name should exist in.Values.fluentBitConfigMaps
.Related issue number
Closes #511
Checks