Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add instructions about how to use SSL/TLS for redis connection. #652

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

fishbone
Copy link
Contributor

Why are these changes needed?

This PR adds the instruction about how to use SSL/TLS for redis connection.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

docs/guidance/gcs-ft.md Outdated Show resolved Hide resolved
Co-authored-by: Simon Mo <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
@kevin85421
Copy link
Member

Thank @iycheng for this contribution!

I am not familiar with Redis, SSL, and TLS. How can I check whether the configuration is set properly and what is the expected behavior (For example, I need to log in to the head pod. Next, execute a command in the pod, and the output will show whether the functionality works successfully or not.)? Thank you!

@fishbone
Copy link
Contributor Author

Thank @iycheng for this contribution!

I am not familiar with Redis, SSL, and TLS. How can I check whether the configuration is set properly and what is the expected behavior (For example, I need to log in to the head pod. Next, execute a command in the pod, and the output will show whether the functionality works successfully or not.)? Thank you!

If the ray cluster runs health, it's working then. I think you need a redis cluster enabled TLS/SSL first. (https://github.com/allen-munsch/docker-redis-ssl-example)
(remember to add rediss:// as the prefix)

@kevin85421
Copy link
Member

Thank @iycheng for this contribution!
I am not familiar with Redis, SSL, and TLS. How can I check whether the configuration is set properly and what is the expected behavior (For example, I need to log in to the head pod. Next, execute a command in the pod, and the output will show whether the functionality works successfully or not.)? Thank you!

If the ray cluster runs health, it's working then. I think you need a redis cluster enabled TLS/SSL first. (https://github.com/allen-munsch/docker-redis-ssl-example) (remember to add rediss:// as the prefix)

Thank you for your reply!

@kevin85421
Copy link
Member

Can I merge this PR? @iycheng @simon-mo

@simon-mo simon-mo merged commit 46d3373 into master Oct 27, 2022
@DmitriGekhtman DmitriGekhtman deleted the update-doc branch December 3, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants