[raycluster controller] Always honor maxReplicas #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <[email protected]>
DmitriGekhtman
requested review from
Jeffwan,
akanso,
kevin85421 and
pcmoritz
|
cc also @sihanwang41 @architkulkarni |
Signed-off-by: Dmitri Gekhtman <[email protected]>
|
Will go ahead and add a test. |
|
Looks good to me! |
Signed-off-by: Dmitri Gekhtman <[email protected]>
|
Will try it out manually as well. |
kevin85421
reviewed
Oct 28, 2022
|
Confirming that I tested it and it works as expected. I think the behavior change should be fairly uncontroversial. |
kevin85421
approved these changes
Oct 28, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Honor max replicas Signed-off-by: Dmitri Gekhtman <[email protected]> * Tweak message. Signed-off-by: Dmitri Gekhtman <[email protected]> * Add to test logic. Signed-off-by: Dmitri Gekhtman <[email protected]> Signed-off-by: Dmitri Gekhtman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitri Gekhtman [email protected]
Why are these changes needed?
If maxReplicas < Replicas, treat maxReplicas as the target replica count and log the discrepancy.
Partly addresses #560 in which some entity (possibly the Ray autoscaler) set replicas > maxReplicas.
See ray-project/ray#29770 for the corresponding safeguard in the autoscaler code.
Related issue number
Checks