[Serve] Define BackendConfig protobuf and adapt it in Java #17201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP][Serve] Define java backend
liuyang-my
added
enhancement
simon-mo
approved these changes
Jul 20, 2021
| Object result = Hessian2Seserializer.decode(initArgsbytes); | ||
| return (Object[]) result; | ||
| } else { | ||
| // TODO |
| @@ -0,0 +1,37 @@ | |||
| package io.ray.serve.serializer; | |||
|
|
|||
| import com.caucho.hessian.io.Hessian2Input; | |||
There was a problem hiding this comment.
Why do we use Hessian as the serialization format here? If it's expected to be used cross language we should use messagepack, if not is Hessian a standard serialization protocol for Java? If so does Ray core use it?
There was a problem hiding this comment.
Hesssian's compatibility is better when adding new properties to the object. But MsgPack performance better in cross-language scenarios. I think MsgPack is the right choice here.
simon-mo
changed the title
|
can you try merge master? the CI failure mostly come that environment issue |
added 10 commits
August 4, 2021 13:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR is about Java users using Ray Serve. We defined the proto file of BackendConfig, so that Python Controller could startup Java Backend Actor.
Detailed design is in doc :https://docs.google.com/document/d/1b9VCZsC2jVhWw_c_ifMu_ED3NxkARcOnU-OFqUYu-r4/edit#heading=h.b3vvz7iwnixn
Related issue number
Checks
scripts/format.shto lint the changes in this PR.