Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker/ci] Build ray-ml docker image for python 3.9 and 3.10 #28123

Merged
merged 10 commits into from
Oct 29, 2022
Merged

[docker/ci] Build ray-ml docker image for python 3.9 and 3.10 #28123

merged 10 commits into from
Oct 29, 2022

Conversation

acxz
Copy link
Contributor

@acxz acxz commented Aug 26, 2022

Why are these changes needed?

Related issue number

Closes #16599

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@acxz acxz requested review from amogkam, krfricke and a team as code owners August 26, 2022 18:16
@amogkam
Copy link
Contributor

amogkam commented Aug 26, 2022

Hey @acxz unfortunately this is not going to work out of the box I believe. There are some dependency issues in our ML requirements. Tracking issue here #16599

@amogkam
Copy link
Contributor

amogkam commented Aug 26, 2022

But I also don’t think building ML images should be a requirement for non-experimental support.

@acxz
Copy link
Contributor Author

acxz commented Aug 26, 2022 •
edited
Loading

I see, I figure we can have a PR open to have the CI running against and see if the error logs have changed since then.

Okay, then I guess we can remove the experimental note off the docs w/o this PR. I had thought py39 was added as experimental due to this reason, so when I added py310 support I added it to the experimental notes with the same rationale.

@stale
Copy link

stale bot commented Sep 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 30, 2022
@acxz
Copy link
Contributor Author

acxz commented Oct 1, 2022

not stale

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 1, 2022
@krfricke krfricke self-assigned this Oct 28, 2022
Merge branch 'master' into ci/ray-ml-39
dbf4866 
# Conflicts:
#	python/requirements/ml/requirements_dl.txt
#	python/requirements/ml/requirements_rllib.txt
@krfricke
Copy link
Contributor

Now that #28808 is merged we can give this another shot. I've just merged master, let's see how the build goes.

@krfricke krfricke changed the title build ray-ml with py39/310 to remove experimental support [docker/ci] Build ray-ml docker image for python 3.9 and 3.10 Oct 28, 2022
Fix cuda images, update h5py
075aa3e 
Signed-off-by: Kai Fricke <[email protected]>
@krfricke
Copy link
Contributor

Python 3.9 seems to pass.

For 3.10, the problem was h5py, which pinned numpy to 1.19.3, which is incompatible with Python 3.10. I've upgraded that dependency.

Additionally, the cuda images were misconfigured in the 3.10 build job previously, this is also fixed.

Update open-spiel
688ab5d 
Signed-off-by: Kai Fricke <[email protected]>
@krfricke
Copy link
Contributor

Image builds are passing, will merge once the rest of the CI is green.

@krfricke
Copy link
Contributor

CI looks fine, will merge if no objections cc @amogkam

Kai Fricke added 3 commits October 28, 2022 18:10
Update dask
09d87b3 
Signed-off-by: Kai Fricke <[email protected]>
Merge remote-tracking branch 'acxz/ray-ml' into ci/ray-ml-39
1401e26 
# Conflicts:
#	python/requirements/data_processing/requirements.txt
dask pin
814c9e6 
Signed-off-by: Kai Fricke <[email protected]>
@krfricke krfricke merged commit 8b3f6f5 into ray-project:master Oct 29, 2022
@acxz
Copy link
Contributor Author

acxz commented Oct 29, 2022

Thanks so much @krfricke and @amogkam for finishing this task up!

@acxz acxz deleted the ray-ml branch October 29, 2022 15:29
@krfricke
Copy link
Contributor

Thanks for the initial contribution @acxz!

WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@acxz @amogkam @WeichenXu123
[docker/ci] Build ray-ml docker image for python 3.9 and 3.10 (ray-pr…
63efcae 
…oject#28123)

This PR updates a few dependencies to be compatible with Python 3.10 and activates build of the ray-ml docker images for Python 3.9 and Python 3.10

Signed-off-by: acxz <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
Co-authored-by: Kai Fricke <[email protected]>
Co-authored-by: Amog Kamsetty <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
@c21 c21 mentioned this pull request Apr 5, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

@richardliaw richardliaw richardliaw approved these changes

@krfricke krfricke krfricke approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977

@matthewdeng matthewdeng Awaiting requested review from matthewdeng

Assignees

@amogkam amogkam

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLlib][Tune] Build Ray-ML docker image for Python 3.9
4 participants
@acxz @amogkam @krfricke @richardliaw