[docs][kubernetes] Update the document for metadata.name and metadata.generateName for Pods #28744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai-Hsun Chen <[email protected]>
kevin85421
force-pushed
the
update-k8s-pod-template-doc
branch
from
dee26f4 to
d9e03c5
Compare
kevin85421
requested review from
wuisawesome,
DmitriGekhtman,
maxpumperla,
pcmoritz and
a team
as code owners
DmitriGekhtman
approved these changes
Sep 27, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ods (ray-project#28744) Update RayCluster config docs to mention that metadata.name and metadata.generateName should not be used. Signed-off-by: Kai-Hsun Chen <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This ray-project/kuberay#587 sets ObjectMeta.Name to an empty string, and use GenerateName to prevent name conflicts. Hence, this document needs to be updated.
Related issue number
Closes #28723
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.