[Cluster Events] Add basic job events. #29164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
architkulkarni
approved these changes
Oct 7, 2022
Signed-off-by: SangBin Cho <[email protected]>
|
Update looks good, feel free to merge once tests pass |
Signed-off-by: SangBin Cho <[email protected]>
|
Failed tests seem unrelated. |
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Oct 8, 2022
This reverts commit 0be4367.
rkooo567
added a commit
that referenced
this pull request
Oct 8, 2022
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Oct 8, 2022
…9164)" (ray-project#29195)" This reverts commit 75a0c49.
rkooo567
added a commit
that referenced
this pull request
Nov 2, 2022
#29196) This reverts the PR and fixes the test failures This also fixes a bug around _monitor_jobs API. the monitor job can be called on the same job twice now, which will break the event (because at the end of monitor job, we record the event that job is completed). The same completed event can be reported twice without the fix
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Dec 6, 2022
…9164)" (ray-project#29… (ray-project#29196) This reverts the PR and fixes the test failures This also fixes a bug around _monitor_jobs API. the monitor job can be called on the same job twice now, which will break the event (because at the end of monitor job, we record the event that job is completed). The same completed event can be reported twice without the fix upgrade gtest to 1.12.1 (ray-project#29902) While working on ray-project#28209 I hit issue google/googletest#3514, which causes a couple gtest-dependent tests to be unable to build Signed-off-by: Pablo E <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
This PR adds basic job submission events. We are creating 2 events (started a job & completed a job). Signed-off-by: Weichen Xu <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ay-project#29195) This reverts commit 0be4367. Signed-off-by: Weichen Xu <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…9164)" (ray-project#29… (ray-project#29196) This reverts the PR and fixes the test failures This also fixes a bug around _monitor_jobs API. the monitor job can be called on the same job twice now, which will break the event (because at the end of monitor job, we record the event that job is completed). The same completed event can be reported twice without the fix Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds basic job submission events. We are creating 2 events (started a job & completed a job).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.