[tune] Fix new output path with new execution path [no_early_kickoff] #33880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <[email protected]>
xwjiang2010
approved these changes
Mar 29, 2023
zhe-thoughts
approved these changes
Mar 29, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ray-project#33880) The new experimental output path (ray-project#33609) and the new experimental execution engine (ray-project#33499) currently don't work together because the new output path is calling a trial executor API directly (which does not exist in the experimental execution engine). This PR calls the correct API on the TrialRunner/TuneController so both features can be tested together. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ray-project#33880) The new experimental output path (ray-project#33609) and the new experimental execution engine (ray-project#33499) currently don't work together because the new output path is calling a trial executor API directly (which does not exist in the experimental execution engine). This PR calls the correct API on the TrialRunner/TuneController so both features can be tested together. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The new experimental output path (#33609) and the new experimental execution engine (#33499) currently don't work together because the new output path is calling a trial executor API directly (which does not exist in the experimental execution engine).
This PR calls the correct API on the TrialRunner/TuneController so both features can be tested together.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.