[Core] Shorten the membership checking time to 5 seconds. #34769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SangBin Cho <[email protected]>
fishbone
approved these changes
Apr 26, 2023
fishbone
reviewed
Apr 26, 2023
|
What's the issue? It's not clear to me from the PR description. |
Signed-off-by: SangBin Cho <[email protected]>
|
But it is not a fundamental fix, so it won't close the issue. |
|
Left some comments on the issue. Still trying to understand the problem. |
|
I am merging this PR as a temporary workaround. |
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
May 1, 2023
…y-project#34769)" This reverts commit 77d5e84.
rkooo567
added a commit
that referenced
this pull request
May 2, 2023
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
May 2, 2023
…nds. (ray-project#34769)" (ray-project#34912)" This reverts commit 9f60a09.
8 tasks
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…t#34769) 60 seconds are too long in case the GCS is restarted. This can unblock the problem when the GCS is restarted, raylets won't be killed. We will discuss the fundamental fix and follow up with it. Signed-off-by: Jack He <[email protected]>
8 tasks
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
…t#34769) 60 seconds are too long in case the GCS is restarted. This can unblock the problem when the GCS is restarted, raylets won't be killed. We will discuss the fundamental fix and follow up with it.
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
60 seconds are too long in case the GCS is restarted. This can unblock the problem when the GCS is restarted, raylets won't be killed. We will discuss the fundamental fix and follow up with it.
Related issue number
Address #34763 short term
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.