Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Core] Put pg state to kv store when pg rescheduling (#34467)" #34914

Merged
merged 1 commit into from
May 2, 2023

Conversation

rkooo567
Copy link
Contributor

@rkooo567 rkooo567 commented May 1, 2023

This reverts commit af018f6.

Why are these changes needed?

This is the only pg change we made recently, so I assume it could be related. I am not 100% sure though. Let's revert and see how it goes.

Screen Shot 2023-05-01 at 10 20 57 AM

cc @larrylian

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 requested a review from a team as a code owner May 1, 2023 17:21
@rkooo567 rkooo567 merged commit 11bf8f5 into ray-project:master May 2, 2023
@rkooo567
Copy link
Contributor Author

rkooo567 commented May 2, 2023

cc @larrylian I will monitor the pg_3 for a while and lyk. Please recreate a revert-revert PR!

@larrylian
Copy link
Contributor

@rkooo567 Okay. I will also look into whether this PR is causing the issue. If it is, I will submit a fix PR at the same time.

@larrylian
Copy link
Contributor

@rkooo567 resubmit PR: #34948

@larrylian
Copy link
Contributor

@rkooo567 I checked the current situation of test_placement_group_3. There will still be flakey use cases. I think the reason for the error should be "bind: Address already in use". This should have nothing to do with my modification above.

image

@rkooo567
Copy link
Contributor Author

yeah that sounds reasonable. Let me merge this PR again.

architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants