[air/output] Switch on per default #35389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 16, 2023 16:56
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
krfricke
requested review from
richardliaw,
gjoliver,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla and
a team
as code owners
krfricke
added
the
tests-ok
matthewdeng
reviewed
May 19, 2023
|
|
||
| IS_NOTEBOOK = ray.widgets.util.in_notebook() | ||
|
|
||
|
|
||
| def get_air_verbosity( | ||
| verbose: Union[int, AirVerbosity, Verbosity] | ||
| ) -> Optional[AirVerbosity]: | ||
| if os.environ.get("RAY_AIR_NEW_OUTPUT", "0") == "0": |
There was a problem hiding this comment.
Update docstring again to reflect this? 😄
| @@ -33,9 +33,9 @@ Context-aware progress reporting | |||
|
|
|||
| .. note:: | |||
|
|
|||
| This feature is *disabled by default* in Ray 2.5. | |||
| This feature is *enabled by default* in Ray 2.5. | |||
There was a problem hiding this comment.
Suggested change
| This feature is *enabled by default* in Ray 2.5. | |
| This feature is *enabled by default* in Ray 2.6. |
added 2 commits
May 23, 2023 19:09
Signed-off-by: Kai Fricke <[email protected]>
matthewdeng
approved these changes
May 23, 2023
jjyao
added a commit
to jjyao/ray
that referenced
this pull request
May 24, 2023
This reverts commit 6e9dfd9.
jjyao
added a commit
that referenced
this pull request
May 25, 2023
krfricke
added a commit
that referenced
this pull request
May 30, 2023
krfricke
added a commit
that referenced
this pull request
May 31, 2023
Reverts #35745 after fixing windows encoding issue. Signed-off-by: Kai Fricke <[email protected]>
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
After ray-project#35129 prepared the switch, this PR actually flicks it: It enables the new context-aware output engine per default. This was moved into a separate PR so it's easily revertible and can be enabled quickly after branch cut. Signed-off-by: Kai Fricke <[email protected]>
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
…project#35745) This reverts commit 6e9dfd9.
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
…"" (ray-project#35895) Reverts ray-project#35745 after fixing windows encoding issue. Signed-off-by: Kai Fricke <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
After ray-project#35129 prepared the switch, this PR actually flicks it: It enables the new context-aware output engine per default. This was moved into a separate PR so it's easily revertible and can be enabled quickly after branch cut. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: e428265 <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…project#35745) This reverts commit 6e9dfd9. Signed-off-by: e428265 <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…"" (ray-project#35895) Reverts ray-project#35745 after fixing windows encoding issue. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
After #35129 prepared the switch, this PR actually flicks it: It enables the new context-aware output engine per default.
This was moved into a separate PR so it's easily revertible and can be enabled quickly after branch cut.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.