-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] gpu memory scheduling prototype #41147
Draft
jonathan-anyscale
wants to merge
14
commits into
ray-project:master
Choose a base branch
from
jonathan-anyscale:ray_gpu_memory
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Core] gpu memory scheduling prototype #41147
jonathan-anyscale
wants to merge
14
commits into
ray-project:master
from
jonathan-anyscale:ray_gpu_memory
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale
force-pushed
the
ray_gpu_memory
branch
from
November 16, 2023 05:31
b246d22
to
89dca92
Compare
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale
force-pushed
the
ray_gpu_memory
branch
from
November 16, 2023 17:23
477d165
to
fc651f5
Compare
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale
force-pushed
the
ray_gpu_memory
branch
from
November 17, 2023 05:46
3f79e06
to
73748ea
Compare
jjyao
reviewed
Nov 17, 2023
Signed-off-by: Jonathan Nitisastro <[email protected]>
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale
force-pushed
the
ray_gpu_memory
branch
5 times, most recently
from
November 21, 2023 06:06
cb8e8f8
to
2d6e187
Compare
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale
force-pushed
the
ray_gpu_memory
branch
from
November 21, 2023 20:48
2d6e187
to
31cf724
Compare
jonathan-anyscale
force-pushed
the
ray_gpu_memory
branch
2 times, most recently
from
November 24, 2023 23:13
acb1222
to
573a45d
Compare
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale
force-pushed
the
ray_gpu_memory
branch
2 times, most recently
from
November 27, 2023 04:39
01fc9a5
to
79a6083
Compare
Signed-off-by: Jonathan Nitisastro <[email protected]>
jonathan-anyscale
force-pushed
the
ray_gpu_memory
branch
from
November 27, 2023 09:15
79a6083
to
550170a
Compare
Signed-off-by: Jonathan Nitisastro <[email protected]>
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prototype to allow user to specify
_gpu_memory
as alternative to specify fractional gpu to the remote function. The field_gpu_memory
defined as "The gpu memory request in megabytes for this task/actor from a single gpu, rounded down to the nearest integer.".Implementation detail:
_gpu_memory
will be converted tonum_gpus
before being scheduled wherenum_gpus = _gpu_memory / gpu_total_memory
and we check if the0 <= num_gpus <= 1
representing fractional GPU request.Implementation Detail
_gpu_memory
is an alternative representation ofnum_gpus
wherenum_ gpus = _gpu_memory / node_total_ gpu_ memory
wherenode_total_gpu_memory
is total gpu memory of the GPU type in the node.Thus, we convert$10^{-4}$ , we rounded up the converted
gpu_memory
toGPU
resource when scheduling depending on what GPU type the scheduled node has and updateGPU
resource value stored inNodeResources
. Additionally, sinceGPU
has precision ofgpu_memory
resource with theGPU
precision.Status
Currently working on cluster with multi-nodes setup, but not working with autoscaler yet.
Why are these changes needed?
Related issue number
Closes #37574
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.