Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] fix test that relies on tight timing #45561

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

aslonnie
Copy link
Collaborator

metrics might not show up immediately

metrics might not show up immediately

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label May 25, 2024
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aslonnie aslonnie merged commit d9761d7 into master May 28, 2024
6 checks passed
@aslonnie aslonnie deleted the lonnie-240525-lagfix branch May 28, 2024 14:20
aslonnie added a commit that referenced this pull request May 28, 2024
aslonnie added a commit that referenced this pull request May 28, 2024
cherrypick #45561

test-only patch; does not change the code under release.

Signed-off-by: Lonnie Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants