-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update visibility of the search button #46237
[Doc] Update visibility of the search button #46237
Conversation
333dff7
to
2cc6824
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you post the screenshot of the button before and after, thankks
Signed-off-by: pdmurray <[email protected]>
2cc6824
to
9dd756a
Compare
BeforeAftercc @simran-2797 |
@simran-2797 It should be, is the test deployment here behaving differently for you? |
Nope. Lgtm. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@can-anyscale Build failure looks unrelated, something about a failure to fetch a mirrorlist when running wanda. Can you double check? I think this should be fine to merge. |
Why are these changes needed?
After #42313 was merged, the contrast of the search button in dark mode is too low. After a discussion in #43566, we are reverting to the default
pydata-sphinx-theme
style for the search button.Related issue number
Closes #43566.
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.