Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update visibility of the search button #46237

Conversation

peytondmurray
Copy link
Contributor

Why are these changes needed?

After #42313 was merged, the contrast of the search button in dark mode is too low. After a discussion in #43566, we are reverting to the default pydata-sphinx-theme style for the search button.

Related issue number

Closes #43566.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@peytondmurray peytondmurray requested a review from a team as a code owner June 25, 2024 00:10
@peytondmurray peytondmurray force-pushed the 43566-fix-search-button-visibility branch from 333dff7 to 2cc6824 Compare June 25, 2024 00:11
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you post the screenshot of the button before and after, thankks

@peytondmurray peytondmurray force-pushed the 43566-fix-search-button-visibility branch from 2cc6824 to 9dd756a Compare June 27, 2024 20:42
@peytondmurray
Copy link
Contributor Author

peytondmurray commented Jun 27, 2024

Before

image

After

image

cc @simran-2797

@peytondmurray peytondmurray added P1 Issue that should be fixed within a few weeks docs An issue or change related to documentation labels Jul 2, 2024
@simran-2797
Copy link
Contributor

Awesome! Lgtm.
Qq: The search behavior still remains the same, right? I click on the search bar and I would see this?
Screenshot 2024-07-03 at 10 17 09 AM

@peytondmurray
Copy link
Contributor Author

peytondmurray commented Jul 3, 2024

@simran-2797 It should be, is the test deployment here behaving differently for you?

@simran-2797
Copy link
Contributor

Nope. Lgtm. Thanks!

Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@angelinalg angelinalg enabled auto-merge (squash) July 3, 2024 18:17
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 3, 2024
@peytondmurray
Copy link
Contributor Author

@can-anyscale Build failure looks unrelated, something about a failure to fetch a mirrorlist when running wanda. Can you double check? I think this should be fine to merge.

@can-anyscale can-anyscale disabled auto-merge July 8, 2024 17:57
@can-anyscale can-anyscale merged commit 300f401 into ray-project:master Jul 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation go add ONLY when ready to merge, run all tests P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Dark mode > search bar has low visibility
4 participants