[ray client] use is / is not on type check #46464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than using == or != Signed-off-by: Lonnie Liu <[email protected]>
jjyao
approved these changes
Jul 7, 2024
kevbanawis
reviewed
Jul 7, 2024
| @@ -96,7 +96,7 @@ def persistent_id(self, obj): | |||
| elif isinstance(obj, ClientRemoteFunc): | |||
| if obj._ref is None: | |||
| obj._ensure_ref() | |||
| if type(obj._ref) == InProgressSentinel: | |||
| if type(obj._ref) is InProgressSentinel: | |||
| return PickleStub( | |||
There was a problem hiding this comment.
Maybe we can use isinstance(ob._refj, InProgressSentinel) here?
Its more concise, readable, and faster?
There was a problem hiding this comment.
@jjyao ? I am just fixing the lint..
instance will also allow sub class instances. I am not sure if it is safe for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than using
==or!=