Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] skip rllib gpu test on premerge #46504

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Jul 9, 2024

too flaky, and taking too long time.

@aslonnie aslonnie requested a review from can-anyscale July 9, 2024 14:33
too flaky, and taking too long time.

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie force-pushed the lonnie-240709-skiprlgpu branch from f60aade to 854ac93 Compare July 9, 2024 14:33
@aslonnie
Copy link
Collaborator Author

aslonnie commented Jul 9, 2024

fyi @sven1977 @simonsays1980

@aslonnie aslonnie merged commit c630ccc into master Jul 9, 2024
3 of 5 checks passed
@aslonnie aslonnie deleted the lonnie-240709-skiprlgpu branch July 9, 2024 14:34
@can-anyscale
Copy link
Collaborator

rllib is pretty active so i worry this will lead to a lot of breakages in master branch

@aslonnie
Copy link
Collaborator Author

aslonnie commented Jul 9, 2024

rllib is pretty active so i worry this will lead to a lot of breakages in master branch

imo it is already broken right now..

@aslonnie
Copy link
Collaborator Author

aslonnie commented Jul 9, 2024

let me see if I can make it that we do not run rllib gpu tests for most people. currently, if any file is not tracked, it will trigger all these rllib tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants