[RLlib] Flatten dict-typed observations before comparing them. #49740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new episodes are added into replay buffers, thier first obs will be compared with the last obs from previous episode in the buffer inside
concat_episode
method to make sure they are same obs:assert np.all(other.observations[0] == self.observations[-1])
Currently these obs are assumed to be pure ndarray, and dict-typed obs will raise
"ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()"
.This PR leverages
flatten_inputs_to_1d_tensor
method fromrllib.utils.numpy
to flatten dict-typed obs before the comparison.