[Refactor] Fix ruff rule E714: Test for object identity should be is not
#49813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not` Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
requested review from
a team,
sven1977 and
simonsays1980
as code owners
aslonnie
approved these changes
Jan 14, 2025
rllib/utils/deprecation.py
Outdated
| @@ -40,7 +40,7 @@ def deprecation_warning( | |||
| ) | |||
|
|
|||
| if error: | |||
| if not type(error) is bool and issubclass(error, Exception): | |||
| if type(error) is not bool and issubclass(error, Exception): | |||
There was a problem hiding this comment.
this should be isinstance(error, bool) ?
There was a problem hiding this comment.
It should be fixed in rule E721, not this PR.
There was a problem hiding this comment.
could you just change it to isinstance here?
There was a problem hiding this comment.
Fixed in b46ff94
jjyao
approved these changes
Jan 14, 2025
34 tasks
Signed-off-by: Chi-Sheng Liu <[email protected]>
Signed-off-by: Lonnie Liu <[email protected]>
aslonnie
approved these changes
Jan 14, 2025
Signed-off-by: Lonnie Liu <[email protected]>
srinathk10
pushed a commit
that referenced
this pull request
Feb 2, 2025
… not` (#49813) Auto-fixed by ruff using pre-commit run ruff --all-files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
As title.
Note: Auto-fixed by
ruffusingpre-commit run ruff --all-files.Related issue number
N/A
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.