-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Prestart worker with runtime env #49994
base: master
Are you sure you want to change the base?
[core] Prestart worker with runtime env #49994
Conversation
Signed-off-by: dentiny <[email protected]>
fbcd4bd
to
4166389
Compare
Signed-off-by: dentiny <[email protected]>
4166389
to
c04f15d
Compare
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some tests
Do you think it good enough to serve as assertion on #50003? |
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. We can merge after adding tests.
Signed-off-by: dentiny <[email protected]>
Test added |
Troubleshooting result for runtime env performance issue:
Reading through the code, if runtime env empty, we prestart worker, otherwise we skip:
ray/src/ray/raylet/worker_pool.cc
Line 1451 in 3bd3865
After the change, the performance is much better: https://buildkite.com/ray-project/release/builds/30878