[Refactor] Fix ruff rule B018: useless-expression #50010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
win5923
requested review from
hongpeng-guo,
justinvyu,
matthewdeng,
raulchen,
woshiyyya,
sven1977,
simonsays1980 and
a team
as code owners
win5923
force-pushed
the
ruff/B018
branch
2 times, most recently
from
19c83d3 to
88955f1
Compare
34 tasks
win5923
commented
Jan 23, 2025
win5923
requested review from
a team,
maxpumperla,
stephanie-wang,
richardliaw,
edoakes and
hongchaodeng
as code owners
Signed-off-by: win5923 <[email protected]>
Signed-off-by: win5923 <[email protected]>
aslonnie
reviewed
Jan 23, 2025
| @@ -4,7 +4,7 @@ | |||
| @serve.deployment | |||
| class A: | |||
| def __init__(self): | |||
| 1 / 0 | |||
| raise ZeroDivisionError | |||
There was a problem hiding this comment.
could you also change this and the other places to _ = 1 / 0
hongpeng-guo
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
The train part looks good to me except https://github.com/ray-project/ray/pull/50010/files#r1927372142
aslonnie
reviewed
Jan 24, 2025
Signed-off-by: win5923 <[email protected]>
srinathk10
pushed a commit
that referenced
this pull request
Feb 2, 2025
Useless expressions have no effect on the program, and are often included by mistake. Assign a useless expression to a variable, or remove it entirely. However, if a seemingly useless expression (like an attribute access) is needed to trigger a side effect, consider assigning it to an anonymous variable, to indicate that the return value is intentionally ignored. --------- Signed-off-by: win5923 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Useless expressions have no effect on the program, and are often included by mistake. Assign a useless expression to a variable, or remove it entirely.
However, if a seemingly useless expression (like an attribute access) is needed to trigger a side effect, consider assigning it to an anonymous variable, to indicate that the return value is intentionally ignored.
Ref: https://docs.astral.sh/ruff/rules/useless-expression/
Related issue number
#47991
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.