[core] Use boost iostream in pipe logger for cross-platform #50044
+166
−269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/boost-windows-jan-23
branch
from
e72abed to
c2c4418
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/boost-windows-jan-23
branch
from
c2c4418 to
8bdd94a
Compare
rynewang
approved these changes
Jan 23, 2025
jjyao
reviewed
Jan 24, 2025
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
jjyao
reviewed
Jan 24, 2025
|
|
||
| namespace { | ||
|
|
||
| TEST_P(PipeLoggerTest, PipeWrite) { |
There was a problem hiding this comment.
Actually why removing this test? Shouldn't we just make it run on all platforms?
There was a problem hiding this comment.
Reason is, the test case is made for (1) pipe write, and check pipe size's effect; (2) log rotation.
Remove because (1) pipe is no longer used in the code; (2) log rotation has been tested elsewhere.
Signed-off-by: dentiny <[email protected]>
jjyao
reviewed
Jan 24, 2025
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
jjyao
approved these changes
Jan 24, 2025
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/boost-windows-jan-23
branch
from
6e0e559 to
5d74185
Compare
|
[2025-01-25T02:42:31Z] //src/ray/util/tests:stream_redirection_utils_test FAILED in 3 out of 3 in 2.2s |
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/boost-windows-jan-23
branch
from
bc12f0b to
e6c6ce1
Compare
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a TODO item, which leverages boost iostreams to achieve cross-platform.