-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update visual-studio-code extension #17491
Conversation
- feat: add support for Positron build - Initial commit
Thank you for your contribution! 🎉 🔔 @thomaspaulmann @iainsimmons @macbookandrew @cy-98 @immint023 @pernielsentikaer @vimtor @tonka3000 @aka-rabbi-inv @oilbeater @QIanGua @hakob8956 @erics118 @tmwrnr @tleo19 @aeither @yug2005 @VatsalSy @Tarocch1 @list-jonas @xilopaint @lacherogwu you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
Seems like cliPath is missing. Are you sure that installing Positron extensions works? You could also add positron as a keyword. It also seems to be missing from the preferences. |
@Nenuial You forgot to add the bundle id in |
- fix: add Positron bundleId - docs: add Positron as keyword
Thank you for you comments. I have added the cliPath, keyword and bundleId. I didn't understand what you meant by:
I have added Positron as an option for the |
I was referring to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds support for Positron, a VS Code-based IDE used by data scientists, to the Visual Studio Code extension.
- Added Positron to the VSCodeBuild enum in
src/types.ts
to support it as a selectable editor option - Added Positron's CLI path (
/Applications/Positron.app/Contents/Resources/app/bin/code
) insrc/lib/vscode.ts
- Added Positron's bundle ID (
com.rstudio.positron
) to the bundleIdMap insrc/utils/editor.ts
- Added Positron to the NewWindowMenuItemIndex in
src/open-new-window.ts
with value 3 - Missing entry for Positron in the
buildSchemes
object insrc/lib/vscode.ts
which could cause issues with extension directory access - Added a new changelog entry at the top of
CHANGELOG.md
with the required{PR_MERGE_DATE}
template
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Did you correct the last things here? |
I'm sorry but I don't see anything in that file that would need to be changed to account for the addition of Positron as a additional build. But again, I'm not that familiar with this extension. The AI review pointed to a missing entry in buildSchemes. I have fixed that. |
@list-jonas can you help? |
I mistakenly referenced a feature removed in the last commit. Please disregard that reference—sorry for any confusion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Looks good to me, approved 🔥
Published to the Raycast Store: |
🎉 🎉 🎉 Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@Nenuial). |
Description
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folderCloses #16400 and closes #16208.