Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visual-studio-code extension #17491

Merged
merged 6 commits into from
Mar 2, 2025

Conversation

Nenuial
Copy link
Contributor

@Nenuial Nenuial commented Mar 2, 2025

Description

Screencast

Checklist

Closes #16400 and closes #16208.

- feat: add support for Positron build
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: visual-studio-code-recent-projects Issues related to the visual-studio-code-recent-projects extension labels Mar 2, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Mar 2, 2025

Thank you for your contribution! 🎉

🔔 @thomaspaulmann @iainsimmons @macbookandrew @cy-98 @immint023 @pernielsentikaer @vimtor @tonka3000 @aka-rabbi-inv @oilbeater @QIanGua @hakob8956 @erics118 @tmwrnr @tleo19 @aeither @yug2005 @VatsalSy @Tarocch1 @list-jonas @xilopaint @lacherogwu you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

@Nenuial
Copy link
Contributor Author

Nenuial commented Mar 2, 2025

This is my attempt to add support for Positron to the Visual Studio Code extension. I have tested all commands with Positron and they seem to work fine. I am however not particularly familiar with the extension and I might have missed something.

This adresses #16208 and #16400.

@list-jonas
Copy link
Contributor

list-jonas commented Mar 2, 2025

Seems like cliPath is missing. Are you sure that installing Positron extensions works?

You could also add positron as a keyword.

It also seems to be missing from the preferences.

@xilopaint
Copy link
Contributor

@Nenuial You forgot to add the bundle id in src/utils/editor.ts

Nenuial added 2 commits March 2, 2025 18:43
- fix: add Positron bundleId
- docs: add Positron as keyword
@Nenuial
Copy link
Contributor Author

Nenuial commented Mar 2, 2025

Thank you for you comments.

I have added the cliPath, keyword and bundleId. I didn't understand what you meant by:

It also seems to be missing from the preferences.

I have added Positron as an option for the build value in package.json. Am I missing something?

@list-jonas
Copy link
Contributor

I was referring to
extensions/visual-studio-code-recent-projects/src/preferences.ts

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds support for Positron, a VS Code-based IDE used by data scientists, to the Visual Studio Code extension.

  • Added Positron to the VSCodeBuild enum in src/types.ts to support it as a selectable editor option
  • Added Positron's CLI path (/Applications/Positron.app/Contents/Resources/app/bin/code) in src/lib/vscode.ts
  • Added Positron's bundle ID (com.rstudio.positron) to the bundleIdMap in src/utils/editor.ts
  • Added Positron to the NewWindowMenuItemIndex in src/open-new-window.ts with value 3
  • Missing entry for Positron in the buildSchemes object in src/lib/vscode.ts which could cause issues with extension directory access
  • Added a new changelog entry at the top of CHANGELOG.md with the required {PR_MERGE_DATE} template

💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@pernielsentikaer
Copy link
Collaborator

Did you correct the last things here?

@Nenuial
Copy link
Contributor Author

Nenuial commented Mar 2, 2025

I was referring to extensions/visual-studio-code-recent-projects/src/preferences.ts

I'm sorry but I don't see anything in that file that would need to be changed to account for the addition of Positron as a additional build. But again, I'm not that familiar with this extension.

The AI review pointed to a missing entry in buildSchemes. I have fixed that.

@pernielsentikaer
Copy link
Collaborator

@list-jonas can you help?

@list-jonas
Copy link
Contributor

list-jonas commented Mar 2, 2025

I mistakenly referenced a feature removed in the last commit. Please disregard that reference—sorry for any confusion!

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 4e2f9e2 into raycast:main Mar 2, 2025
2 checks passed
@Nenuial Nenuial deleted the ext/visual-studio-code branch March 2, 2025 21:49
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Published to the Raycast Store:
https://raycast.com/thomas/visual-studio-code

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@Nenuial).
Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: visual-studio-code-recent-projects Issues related to the visual-studio-code-recent-projects extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Visual Studio Code] Support Positron [Visual Studio Code] Add support for Positron
5 participants